-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching for symbol in big binary lags UI. #6847
Comments
Which search feature are you using? We have quite a few. Please list the steps you used to exhibit the behavior. Most searching is done in the background. This leaves the UI free to paint without being sluggish. It's possible there is a a bug, but it could also be that your system is running into a resource issue, like not enough RAM. |
The stuck feature is "Symbol Tree" on the left side. If it's stuck, it's always with "Expanding nodes..." text. I just encountered it. Ghidra is not responding, there is 13GB of memory left, and CPU usage is at 50% total. |
I see. A thread dump will help us determine what is happening when you get into this state. From a terminal you can run these commands:
|
Sure thing. As previously, Ghidra is stuck on (*was, by the time I wrote that, extracted log, and took screenshot, it unfroze itself, approx 3-4 min.) Expanding nodes... |
Something to try: before you open your binary, you can open the Code Browser and then close the Symbol Tree. After re-opening your binary, see if the issue persists. I'd like to isolate the Symbol Tree to verify that is the issue. |
The issue appears to be an infinite loop inside of the Mac
We been working on accessibility over the last year. It's possible we have introduce code that can trigger this infinite loop. We will investigate this. |
This may be related this: |
The issue only appears when the Filter field is populated with something. I can try using CMD+T symbol menu and report back, but I think it's highly related to revealing these trees. I don't have any accessibility options enabled but I can try the solution provided in linked issue. |
Also, is there any recommended JDK version for Ghidra ? I was using the newest one before, and switched to mentioned JBR17 and I already can see difference in snappiness of Ghidra (maybe just a placebo though). |
This is the link we provide on the main github page (jdk 21): https://adoptium.net/temurin/releases/ You can always try different implementations as needed. I don't have a personal recommendation for what is best on the Mac. |
Seems like JDK 17 fixed my issue. Even more, Ghidra feels a lot snappier, now I'm certain thats the case. Thanks! |
Is your feature request related to a problem? Please describe.
Trying to search for a symbol in a big binary freezes / heavily lags UI.
Describe the solution you'd like
Add option to make search field ("Filter" field to be precise) do it's action on some user feedback. For example clicking "enter" key. Sometimes updating results on every key input makes it extremely slow.
The text was updated successfully, but these errors were encountered: