Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeadwayJourneyGroupGroup introduces a Description which is already present in GroupOfEntitiesGroup #748

Closed
skinkie opened this issue Jul 2, 2024 · 8 comments
Closed

HeadwayJourneyGroupGroup introduces a Description which is already present in GroupOfEntitiesGroup #748

skinkie opened this issue Jul 2, 2024 · 8 comments
Assignees
@ue71603
Labels
bug Technical mistake, inconsistency with the documentation, etc. document has been updated NeTEx Document already updated
Milestone
netex_2.0

Comments

@skinkie
Copy link
Contributor

skinkie commented Jul 2, 2024

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/netex_part_2/part2_journeyTimes/netex_vehicleJourneyFrequency_version.xsd#L294

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/netex_framework/netex_genericFramework/netex_grouping_version.xsd#L108

warning: Converting parent field {http://www.netex.org.uk/netex}GroupOfEntities_VersionStructure::Description to a list to match child class {http://www.netex.org.uk/netex}HeadwayJourneyGroup

Removing the extra Description in HeadwayJourneyGroupGroup resolves the issue.

In Next the same would go for PathLinkInSequenceGroup, removing the extra Description resolves the issue.
@skinkie skinkie added the bug Technical mistake, inconsistency with the documentation, etc. label Jul 2, 2024
@ue71603
Copy link
Contributor

ue71603 commented Jul 2, 2024

@skinkie ok for me to remove it. Two PR? one to master and one to next?

@skinkie
Copy link
Contributor Author

skinkie commented Jul 2, 2024

I have to check if the PathLinkInSequenceGroup is also in master.

@skinkie
Copy link
Contributor Author

skinkie commented Jul 9, 2024

This is the same thing as #562

@ue71603
Copy link
Contributor

ue71603 commented Jul 9, 2024

@skinkie PR to remove it?

@Aurige
Copy link
Contributor

Aurige commented Aug 30, 2024

If that does not break examples (which is most most likely) I would remove this extra Description

@ue71603 ue71603 assigned ue71603 and unassigned nick-knowles, Aurige and ue71603 Sep 24, 2024
@ue71603 ue71603 added this to the netex_2.0 milestone Sep 24, 2024
@ue71603 ue71603 added the needs documentation update The NeTEx document needs to be updated label Sep 24, 2024
@ue71603 ue71603 mentioned this issue Sep 30, 2024
Merged
@ue71603
Copy link
Contributor

ue71603 commented Sep 30, 2024

PR done

@ue71603 ue71603 closed this as completed Sep 30, 2024
@skinkie
Copy link
Contributor Author

skinkie commented Sep 30, 2024

@ue71603 will you do it for PathLinkInSequenceGroup as well?

@ue71603 ue71603 mentioned this issue Sep 30, 2024
Closed
@Aurige
Copy link
Contributor

Aurige commented Oct 29, 2024

Doc updated via #783

@Aurige Aurige added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ue71603 ue71603

Labels
bug Technical mistake, inconsistency with the documentation, etc. document has been updated NeTEx Document already updated
Projects
None yet
Milestone
netex_2.0
Development

No branches or pull requests
4 participants
@skinkie @nick-knowles @Aurige @ue71603