Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide transaction hash instead of receipt id when finalizing transactions on Ethereum #12

Open
kiseln opened this issue Jul 24, 2024 · 0 comments

Comments

@kiseln
Copy link
Contributor

kiseln commented Jul 24, 2024

This improvement can be done for the following methods:

  • deploy token for nep-141 connector
  • finalize deposit in nep-141 connector
  • finalize withdraw in eth connector

Implementation

To achieve this we need to be able to find the required receipt within the transaction. We want to use EXPERIMENTAL_tx_status RPC request to retrieve transaction receipts and find the receipt corresponding to the required action.

The simplest approach would be to use https://github.com/near/near-jsonrpc-client-rs to get the receipts. However, due to an issue in how one of the structures is deserialized we don't get the proper result (issue discussed here)

We either need to fix the issue with FinalExecutionOutcomeView or invoke the RPC directly without the client library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant