Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime error when running mode ON and ONB with ls larger than ns #228

Open
Ping-Hsuan opened this issue Aug 30, 2024 · 0 comments
Open
Assignees

Comments

@Ping-Hsuan
Copy link
Collaborator

Ping-Hsuan commented Aug 30, 2024

Currently, in NekROM ns is set to ls by default (it is set in subroutine mor_init_params of rom.f)

However, in mor_set_params_par, if one is using mode 'ON' or mode 'ONB,' the code will set nns variable, which will be used in later when loading uk arrays, by reading the value in ops/ns and raise an error if the read value is less than ns. Because ns is set to be ls by default, if users set ls to be larger than ns (which is valid), the code yields a runtime error: ms less than ns...

One can bypass this issue by explicitly setting ns in the par file. However, we should fix this so that ls can be larger than ns.

@Ping-Hsuan Ping-Hsuan self-assigned this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant