Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Dataset masking UI should display a brush outline matching current brush size #569

Open
O-J1 opened this issue Nov 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@O-J1
Copy link
Collaborator

O-J1 commented Nov 17, 2024

Describe your use-case.

Dataset masking UI should display a brush outline matching current brush size. Low prio but also likely relatively easy.

What would you like to see as a solution?

A thin circular outline that changes after the user scrolls, matching the current brush size.

Have you considered alternatives? List them here.

N/A

@O-J1 O-J1 added the enhancement New feature or request label Nov 17, 2024
@Arcitec
Copy link
Contributor

Arcitec commented Nov 18, 2024

I agree it would be nice. But we are at the mercy of TkInter and CustomTkInter GUI toolkits which have no features at all for image editing, and may not even have custom cursor support, so I don't think this is easy or maybe even doable.

We don't have a brush. Everything about the current mask editor is faked by just catching the click event and coordinates. 😉

@O-J1
Copy link
Collaborator Author

O-J1 commented Nov 19, 2024

I agree it would be nice. But we are at the mercy of TkInter and CustomTkInter GUI toolkits which have no features at all for image editing, and may not even have custom cursor support, so I don't think this is easy or maybe even doable.

We don't have a brush. Everything about the current mask editor is faked by just catching the click event and coordinates. 😉

I’m aware of what we are using, you don’t need to tell me don’t worry. This isn’t my request either, it’s a transferred user request. As for doability, I made an extremely shitty version and it worked. So my assessment is from that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants