Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

conductor-es7-persistence in maven repo is over packages. #184

Open
DukeDai opened this issue Feb 23, 2023 · 0 comments
Open

conductor-es7-persistence in maven repo is over packages. #184

DukeDai opened this issue Feb 23, 2023 · 0 comments

Comments

@DukeDai
Copy link

DukeDai commented Feb 23, 2023

Describe the bug
conductor-es7-persistence in maven repo is a shadow jar with many dependencies packaged directly.
One side effect as I know if integrating it with conductor, spring boot actuator endpoints will not be enabled so no way to leverage features supported by actuator, for example, metrics/prometheus.

Details
Conductor version: 3.13.3
Persistence implementation: Cassandra, Postgres, MySQL, Dynomite etc
Queue implementation: Postgres, MySQL, Dynoqueues etc
Lock: Redis or Zookeeper?
Workflow definition:
Task definition:
Event handler definition:

To Reproduce
Download the jar and check its size or unzip it.

Expected behavior
jar in maven repo should be a lightweight jar instead of shadow jar with full of dependencies embedded.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

file index/es7-persistence/build.gradle

`
// Drop the classifier and delete jar task actions to replace the regular jar artifact with the shadow artifact
shadowJar {
configurations = [project.configurations.shadow]
classifier = null

// Service files are not included by default.
mergeServiceFiles {
    include 'META-INF/services/*'
    include 'META-INF/maven/*'
}

}

jar.enabled = false
jar.dependsOn shadowJar
`

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant