From cafbe81a6c22128cafbbb7b90b2d107501a28e44 Mon Sep 17 00:00:00 2001
From: Andy Zhang <87735571+Andyz26@users.noreply.github.com>
Date: Tue, 15 Aug 2023 21:21:03 -0700
Subject: [PATCH] Improve dead letter log (#527)

* Improve deadletter log

* TE warn to debug
---
 .../src/main/java/io/mantisrx/master/DeadLetterActor.java  | 7 +++++--
 .../master/resourcecluster/ResourceClusterActor.java       | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/DeadLetterActor.java b/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/DeadLetterActor.java
index 5569a38aa..2d8f27cad 100644
--- a/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/DeadLetterActor.java
+++ b/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/DeadLetterActor.java
@@ -46,8 +46,11 @@ public Receive createReceive() {
                 .match(DeadLetter.class, msg -> {
                     this.numDeadLetterMsgs.increment();
                     String m = toString(msg.message());
-                    log.error("Dead Letter from {} to {} msg:{}", msg.sender(), msg.recipient(),
-                            m.substring(0, Math.min(250, m.length() - 1)));
+                    log.error("Dead Letter from {} to {} msg type: {} payload: {}",
+                        msg.sender(),
+                        msg.recipient(),
+                        msg.message().getClass().getSimpleName(),
+                        m.substring(0, Math.min(250, m.length() - 1)));
                 })
                 .build();
     }
diff --git a/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/resourcecluster/ResourceClusterActor.java b/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/resourcecluster/ResourceClusterActor.java
index 571ecea00..ef1c5b6dd 100644
--- a/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/resourcecluster/ResourceClusterActor.java
+++ b/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/resourcecluster/ResourceClusterActor.java
@@ -775,7 +775,7 @@ private void onCacheJobArtifactsOnTaskExecutorRequest(CacheJobArtifactsOnTaskExe
             }
         }
         else {
-            log.warn("no valid TE state for CacheJobArtifactsOnTaskExecutorRequest: {}", request);
+            log.debug("no valid TE state for CacheJobArtifactsOnTaskExecutorRequest: {}", request);
         }
     }