Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pure interfaces for injectable classes #133

Open
wmiaw opened this issue Sep 9, 2016 · 1 comment
Open

Create pure interfaces for injectable classes #133

wmiaw opened this issue Sep 9, 2016 · 1 comment
Assignees

Comments

@wmiaw
Copy link
Contributor

wmiaw commented Sep 9, 2016

Some of the injectable classes are currently defined as abstract or inheritable base classes. This is mostly to provide a fully functional implementation that can be extended or have methods overridden for customization purposes. However from a design standpoint it may be better to define them as pure interfaces with the current base class becoming a concrete example.

@wmiaw wmiaw self-assigned this Sep 9, 2016
@quidryan
Copy link
Contributor

👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants