Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of writev in batching handler #120

Open
ScottMansfield opened this issue Apr 12, 2017 · 0 comments
Open

Take advantage of writev in batching handler #120

ScottMansfield opened this issue Apr 12, 2017 · 0 comments

Comments

@ScottMansfield
Copy link
Contributor

Go 1.8 has a new net.Buffers type which enables the use of writev on systems that support that syscall. The batching backend currently has a process where it writes all requests into a single buffer before sending it out the socket. This should be converted to use the net.Buffers type ([][]byte) in order to gain some efficiency by doing less copying.

There are probably more opportunities to use this type in more places, but they will come separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant