Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NethVoice: default phone template disappear if is not used #7289

Closed
andrea-marchionni opened this issue Jan 29, 2025 · 1 comment
Closed
Assignees
Labels
nethvoice Bug or features releted to the NethVoice project
Milestone

Comments

@andrea-marchionni
Copy link

andrea-marchionni commented Jan 29, 2025

If I create a custom template for a phone model and assign it to all phones of that model, the original base model— from which the custom template was created—disappears from the list of available models.

Steps to Reproduce:

  1. Add a phone using its MAC address.
  2. Assign the phone to a user.
  3. Create a custom template for the phone model.
  4. Change the phone’s model.
  5. The original base model no longer appears in the list on the model page.
@andrea-marchionni andrea-marchionni converted this from a draft issue Jan 29, 2025
@andrea-marchionni andrea-marchionni added the nethvoice Bug or features releted to the NethVoice project label Jan 29, 2025
@andrea-marchionni andrea-marchionni added this to the NethVoice 1.2 milestone Jan 29, 2025
@Stell0 Stell0 self-assigned this Feb 6, 2025
@Stell0
Copy link

Stell0 commented Feb 6, 2025

The problem is that when the original model scope is modified isn't shown as a scope to copy from for creating a derived one.
Image
This is because the API used to populate the list is tancredi/models?filter[used], that show only scope used by a device. Without filter, all available scopes would be shown.
Consequence is that we can't show a model if it doesn't have a phone associated with it.
But it's ok, because it makes no sense to modify a scope that isn't used by any phone.
To have the original scope in that list, you can just add a phone, assign the parent scope model to it then you can modify it.

@Stell0 Stell0 closed this as completed Feb 6, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in NethVoice Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nethvoice Bug or features releted to the NethVoice project
Projects
Status: Done
Development

No branches or pull requests

2 participants