NS7 migration: handle space in share samba name

[stephdl]

The migration from NS7 to NS8 is broken when you use samba shares with spaces in the name of the share
Steps to reproduce

• install a NS7 with account provider AD
• creates some samba shares with a space inside the name
• install ns8 migration
• try to migrate to a NS8

Expected behavior

I expect no issue

Actual behavior

we cannot migrate the server, once connected, no error so far, we try to migrate the account provider, however we cannot finish the migration, we have errors in the UI and with errors in logs

mode of '/srv/shares' changed from 0775 (rwxrwxr-x) to 0755 (rwxr-xr-x)
Now reading shares metadata from stdin...
Enabled share foo
Enabled share helene foo
setfacl: /srv/shares/helene: No such file or directory
setfacl: foo: No such file or directory
Traceback (most recent call last):
  File "/home/samba1/.config/actions/import-module/80import_shares", line 46, in <module>
    subprocess.run(['podman', 'exec',
  File "/usr/lib64/python3.11/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['podman', 'exec', '--interactive', '--env=RSYNCD_NETWORK=10.5.4.0/24', '--env=RSYNCD_ADDRESS=10.5.4.1', '--env=RSYNCD_PORT=20003', '--env=RSYNCD_USER=samba1', '--env=RSYNCD_PASSWORD=520047505c45-aadb-4abc-adce-64d3aaf3212e', '--env=RSYNCD_SYSLOG_TAG=samba1', 'samba-dc', 'rsyncd-import-shares']' returned non-zero exit status 123.

Components

https://github.com/NethServer/ns8-samba/releases/tag/2.3.0

See also

see https://mattermost.nethesis.it/nethesis/pl/pw6gsotcc7gmtfr5xa3ebh7g1o

[DavidePrincipi]

In testing 2.3.1-dev.2

Test case

Check the bug is not reproducible.

• create samba share name with spaces
• add files with spaces in name

no issue to migrate the AD + samba file system to NS8

[nrauso]

test case VERIFIED

[DavidePrincipi]

Released in https://github.com/NethServer/ns8-samba/releases/tag/2.3.1