Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedData should be updated to support SNIP12 #636

Open
dkatzan opened this issue Oct 6, 2024 · 0 comments
Open

TypedData should be updated to support SNIP12 #636

dkatzan opened this issue Oct 6, 2024 · 0 comments

Comments

@dkatzan
Copy link
Contributor

dkatzan commented Oct 6, 2024 •
edited
Loading

Hi, it looks like the currenty typed data implementation is not conforming to the SNIP12 standard

some specifics gaps seems to be:

  1. missing optional revision from Domain
  2. Definition is missing an optional contains field, which should exist iff type is enum or merkleTree
  3. Should rename StarkNetDomain to StarketDomain
  4. fields under Domain should be treated as ShortStr instead of felts

The hashing itself is also currently using PEDERSEN instead of Poseidon
and there is lack for encoding all non felt types

are there any plans, or WIP to implement support for the formal SNIP?
Thx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkatzan