Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve model standard detection from files #435

Open
sanjayankur31 opened this issue Nov 6, 2024 · 0 comments · May be fixed by #436
Open

Improve model standard detection from files #435

sanjayankur31 opened this issue Nov 6, 2024 · 0 comments · May be fixed by #436
Labels
T: enhancement Type: enhancement

Comments

@sanjayankur31
Copy link
Member

See: OpenSourceBrain/SBMLShowcase#77

At the moment, we detect files using their file extensions, but this isn't perfect because people may just use "xml" for files, in which case our tests will fail.

So, what we should do is:

  • check the extension
  • if that fails, for example, if it's "xml" which is ambigious, we read the first and last N lines of the file to grep them for tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: enhancement Type: enhancement
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

1 participant