Is this code redundant?

[allwaysFindFood]

moabb/moabb/evaluations/evaluations.py

Line 196 in bea3ec0

)

moabb/evaluations/evaluations.py

The lines 187-196 don't return any and the parameters don't match those below—are these redundant code?

[bruAristimunha]

Hey @allwaysFindFood,

maybe, but we want to remove this type of evaluation and depend only on splitters. This whole part of the evaluation will be refactored for better future maintainability, if you have any feedback or wishes, please let me know

[gcattan]

@bruAristimunha may be we can welcome a PR to fix the existing evaluation. I suspect it will still live for some time, before being removed. What do you think?

[bruAristimunha]

I really hope not too long, we are working on the Moabb meeting every two weeks to try to prioritize what is blocked.

Regarding the reported line, basically in the folder creation function we have two behaviors that are controlled by the same flag. It seems redundant, but it wasn't at the time it was proposed.

Definitely needs some refinement, but we already we will do this soon.