Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WildApricot Phone number field character count and type exceeded Quickbooks allotment #119

Open
Crednib opened this issue Jan 8, 2025 · 1 comment
Labels
bug Something isn't working minor-update Estimated as a minor change - suggest bundling with other minor changes QBO QuickBooks Online

Comments

@Crednib
Copy link

Crednib commented Jan 8, 2025

Maryland Native Plant Society invoice #12904 in September 2024 and coinciding payment was not processed during the Make scenario run. It was not notated as an Error on the confirmation so it was not noticed until December 2024.
Speaking with Dave Reed it appears that it was rejected by Quickbooks. Dave will update the Error messaging on the confirmation emails to recognize this situation.

@thelontx
Copy link
Collaborator

thelontx commented Jan 8, 2025

Additional background and root cause:

  • Quickbooks rejected customer creation because the QB phone field is limited to 30 characters. MNPS used the phone field as a notes field and included 3 separate phone numbers.
  • The existing Error handling route was focused on "Validation Fault: Duplicate Name...". In this case, the Error Message was "ValidationFault: String length...". As a result, the bundle (specific invoice) errored out and was not processed by the rest of the scenario.
  • Though it is not good that the scenario failed to process, it is good to understand additional failure modes and handle appropriately.

Expected fix: (looks complex, but it is simple)

  • In the error handling route after customer creation (module 214), update the existing filter.
    • Updated filter name: Customer creation fault (instead of duplicate customer).
    • Updated filter logic: Replace the second condition of "Validation Fault: Duplicate Name" with "Validation Fault"
  • In the error handling routes following each create transaction module, update the logic in the Resume module for the specified notes fields. The subsequent "compose html string" module used this notes field to pass the customer creation message to the email summary. In the if() function, replace the "Potential Duplicate Customer" phrase with "QBO Customer Creation Issue". This is being changed to be less confusing in the automated email. Even if this is not changed, the error message will pass properly. These are the fields in the error handling route in which the logic must be updated:
    • Invoice: Private Note
    • Payment: Private Note
    • Sales Receipt: Tools Set variables Module - ErrorCustomMessage

NOTE: This has been manually updated for MNPS.

@thelontx thelontx added bug Something isn't working QBO QuickBooks Online minor-update Estimated as a minor change - suggest bundling with other minor changes labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor-update Estimated as a minor change - suggest bundling with other minor changes QBO QuickBooks Online
Projects
None yet
Development

No branches or pull requests

2 participants