Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Belos: replace Belos Tpetra HarwellBoeing reader usage by Tpetra::Utils::readHBMatrix #210

Open
tlamonthezie opened this issue Sep 22, 2023 · 0 comments · May be fixed by #214
Open

Belos: replace Belos Tpetra HarwellBoeing reader usage by Tpetra::Utils::readHBMatrix #210

tlamonthezie opened this issue Sep 22, 2023 · 0 comments · May be fixed by #214
Assignees
Labels
EpetraMPI T2 NGA-internal NGA workers will take care of these pkg: Belos

Comments

@tlamonthezie
Copy link
Collaborator

tlamonthezie commented Sep 22, 2023

Prerequities:

It is better if all Belos Tpetra examples an tests worked on this fork are merged first. Because we have to update multiple examples and tests in the Belos package using the Belos Tpetra HarwellBoeing reader

Detail

As mentioned in #183 comments:

  1. In all Tpetra tests and examples from Belos: remove usage of Belos::Tpetra::HarwellBoeingReader (using internally TriUtil to read matrix)
Belos::Tpetra::HarwellBoeingReader<Tpetra::CrsMatrix<ST> > reader( comm );
RCP<Tpetra::CrsMatrix<ST> > A = reader.readFromFile( filename );
RCP<const Tpetra::Map<> > map = A->getRowMap();

and replace by the Tpetra version

RCP<MAT> A;
Tpetra::Utils::readHBMatrix(filename, comm, A);
RCP<const MAP> map = A->getRowMap();`

Important: Use the updated version of osrirr1.hb if needed as already provided in TFQMR example directory from #183 (old version used by epetra tests/examples fails to be read by the Tpetra readHBMatrix method)

  1. Finally remove the Belos HarwellBoeingReader class (remove file belos/tpetra/src/BelosTpetraTestFramework.hpp) and TriUtil requirements for the Tpetra tests and examples as it should not be used anymore
@tlamonthezie tlamonthezie self-assigned this Sep 22, 2023
@tlamonthezie tlamonthezie changed the title Belos: replace TriUtil HarwellBoeing reader by Tpetra HarwellBoeing reader in Tpetra tests and examples Belos: replace Belos HarwellBoeing reader usage by Tpetra::Utils::readHBMatrix Sep 22, 2023
@tlamonthezie tlamonthezie added EpetraMPI T2 NGA-internal NGA workers will take care of these pkg: Belos labels Sep 22, 2023
@tlamonthezie tlamonthezie changed the title Belos: replace Belos HarwellBoeing reader usage by Tpetra::Utils::readHBMatrix Belos: replace Belos Tpetra HarwellBoeing reader usage by Tpetra::Utils::readHBMatrix Sep 22, 2023
tlamonthezie added a commit that referenced this issue Sep 22, 2023
tlamonthezie added a commit that referenced this issue Sep 22, 2023
tlamonthezie added a commit that referenced this issue Sep 25, 2023
tlamonthezie added a commit that referenced this issue Sep 25, 2023
tlamonthezie added a commit that referenced this issue Sep 25, 2023
tlamonthezie added a commit that referenced this issue Sep 25, 2023
@tlamonthezie tlamonthezie linked a pull request Sep 25, 2023 that will close this issue
tlamonthezie added a commit that referenced this issue Sep 25, 2023
tlamonthezie added a commit that referenced this issue Sep 25, 2023
tlamonthezie added a commit that referenced this issue Sep 25, 2023
tlamonthezie added a commit that referenced this issue Sep 26, 2023
tlamonthezie added a commit that referenced this issue Sep 26, 2023
tlamonthezie added a commit that referenced this issue Sep 26, 2023
tlamonthezie added a commit that referenced this issue Sep 26, 2023
tlamonthezie added a commit that referenced this issue Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EpetraMPI T2 NGA-internal NGA workers will take care of these pkg: Belos
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant