Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update symfony #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update symfony #19

wants to merge 2 commits into from

Conversation

youngbobby
Copy link

Update Symfony/process to fix conflict with Laravel

@NinoSkopac
Copy link
Owner

NinoSkopac commented Sep 22, 2019

Hello and thank you. I’ll review this tomorrow (this requires a version bump to >=7.2) and release a new minor(major?) version.

@youngbobby
Copy link
Author

I'm not sure. Laravel does require >=7.2 at the moment anyway. Please let me know your findings.

@NinoSkopac
Copy link
Owner

After this is merged and released, minor version will be bumped (https://blog.whiteoctober.co.uk/index.html%3Fp=3415.html)

@NinoSkopac
Copy link
Owner

NinoSkopac commented Sep 23, 2019

@youngbobby I've just pushed a commit with proper PHP and PHPUnit versions, however, I'm unable to get the tests running.

Running ./vendor/bin/phpunit returns No tests executed! - I need the tests to pass before merging.

Can you assist?

@youngbobby
Copy link
Author

Very weird. I experience the same issue too.

@youngbobby
Copy link
Author

Any update with this ?

I really need to use this awesome package.

@NinoSkopac
Copy link
Owner

No, I never got down to figuring this out, so it's stuck.

@youngbobby
Copy link
Author

youngbobby commented Oct 10, 2019

Any idea how I can install manually like from this issue #1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants