Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs implementation should look up bucket and key names from the CloudFormation stack if not specified #15

Closed
psiniemi opened this issue Feb 1, 2018 · 4 comments · Fixed by #43
Closed

nodejs implementation should look up bucket and key names from the CloudFormation stack if not specified #15

psiniemi opened this issue Feb 1, 2018 · 4 comments · Fixed by #43
Assignees
@ehuisman

Comments

@psiniemi
Copy link
Member

psiniemi commented Feb 1, 2018

Only region should be mandatory and is often specified in the environment.
@psiniemi
Copy link
Member Author

psiniemi commented Feb 1, 2018

See https://github.com/NitorCreations/vault/blob/master/python/n_vault/vault.py#L28

@ehuisman ehuisman self-assigned this Mar 29, 2018
@ehuisman
Copy link
Contributor

ehuisman commented Oct 1, 2019

I've been working on this today. The asynchronous nature of the aws-sdk and the limitations of aws-sdk-mock have made it harder than I'd prefer.

@ehuisman ehuisman mentioned this issue Oct 1, 2019
Closed
@jsyrjala
Copy link
Member

jsyrjala commented Nov 7, 2019

Needed also for integration testing #25

@ehuisman
Copy link
Contributor

ehuisman commented Dec 2, 2019

Closed by #43

@ehuisman ehuisman closed this as completed Dec 2, 2019
@ehuisman ehuisman mentioned this issue Dec 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehuisman ehuisman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Node.js CLI NitorCreations/vault
3 participants
@jsyrjala @psiniemi @ehuisman