Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress_build_logs and upload_logs_to_binary_cache are mutually exclusive and badly conflict with one another #1338

Open
delroth opened this issue Jan 12, 2024 · 0 comments
Labels

Comments

@delroth
Copy link
Contributor

delroth commented Jan 12, 2024

Describe the bug

Both the compress_build_logs and upload_logs_to_binary_cache config options try to exclusively handle log files fetched by Hydra from its builders. Both do different things with the log file, but both unlink() the original file once they're done, so it should be pretty obvious they can never work together.

This is especially bad since compress_build_logs is enabled by default.

To Reproduce
Enable both settings, notice that some logs are not uploaded to the cache, and notice that hydra-notify fails to bzip2 a large percentage of logs.

Expected behavior
Either make those not conflict, or error out when this configuration is found.

Screenshots
n/a

Hydra Server:

hydra.nixos.org

Additional context
This is likely the reason why hydra.nixos.org has had randomly missing logs for years. We've found 72M stranded .bz2 log files on the local drive of the Hydra server, which are all log files that likely haven't been uploaded to S3...

@delroth delroth added the bug label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant