Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dlib Python package does not respect cudaSupport from the given dlib library derivation #243880

Open
hacker1024 opened this issue Jul 17, 2023 · 3 comments · May be fixed by #273665
Open

The dlib Python package does not respect cudaSupport from the given dlib library derivation #243880

hacker1024 opened this issue Jul 17, 2023 · 3 comments · May be fixed by #273665

Comments

@hacker1024
Copy link
Member

Describe the bug

The Dlib Python package sets build flags in a different way to the library.

It does not add the flag to enable CUDA support, even if the library derivation has been configured to do so.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Build python3Packages.dlib
  2. Note that dlib.DLIB_USE_CUDA is false, even though the dlib derivation has CUDA enabled

Expected behavior

The CUDA setting should be preserved.

Additional context

The way that python3Packages.dlib inherits values from dlib is very problematic in general. Notably, the link to the derivation source code from search.nixos.org goes to the wrong place.

Notify maintainers

@Ma27 @christopherpoole

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-linux"`
 - host os: `Linux 5.10.104-tegra, Ubuntu, 20.04.6 LTS (Focal Fossa), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.16.1`
 - channels(root): `"jetpack, nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`
@RobbieBuxton
Copy link
Contributor

This should be closed now as a PR to fix this has been merged #279927

@hacker1024
Copy link
Member Author

#279927 does not fix the Python package. See the Python changes in #273665.

@RobbieBuxton
Copy link
Contributor

#279927 does not fix the Python package. See the Python changes in #273665.

Ah does it not? Annoying, I was just testing for c++, hoped the fix would propagate through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
3 participants