Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate CODEOWNERS file programmatically across path changes #265351

Closed
ShamrockLee opened this issue Nov 3, 2023 · 1 comment
Closed

Validate CODEOWNERS file programmatically across path changes #265351

ShamrockLee opened this issue Nov 3, 2023 · 1 comment

Comments

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Nov 3, 2023

Issue description

There's currently no automatical ways to validate the paths inside the CODEOWNERS file. When files or directories are renamed, the path patterns may become invalid, but the error would be ignored silently across the PR review, unless the author found it during search/replace or when it is pointed out by a reviewers. It is very likely that no one ever thought about that file, and it doesn't get included in the path-changing PR at all.

I encountered this issue when working on #262648.

Steps to reproduce

  1. Make a feature branch inside a Nixpkgs fork.
  2. Rename an arbitrary path mentioned inside CODEOWNERS.
  3. Update the files other than CODEOWENRS referencing the changed path, to make the build passes.
  4. Run nixpkgs-review rev HEAD, and make sure there's no unrelated problems.
  5. Make a draft pull request in the comparison page of the base branch and the feature branch.
  6. See it passes all the changes. The CODEOWNERS path invalidation silently passes all the test cases.

Technical details

  • system: "x86_64-linux"
  • host os: Linux 6.1.55, NixOS, 23.05 (Stoat), 23.05.20231007.5a237ae
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.15.2
  • nixpkgs: /nix/store/3fdrwsy2yi8rwxqylpd6vi2asraxq1nv-source
@ShamrockLee ShamrockLee changed the title [Feture Request] Validate CODEOWNERS file programmatically across path changes Validate CODEOWNERS file programmatically across path changes Nov 3, 2023
@FliegendeWurst
Copy link
Member

Done in #336261 by switching to homegrown codeowner solution.

@FliegendeWurst FliegendeWurst closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants