You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's currently no automatical ways to validate the paths inside the CODEOWNERS file. When files or directories are renamed, the path patterns may become invalid, but the error would be ignored silently across the PR review, unless the author found it during search/replace or when it is pointed out by a reviewers. It is very likely that no one ever thought about that file, and it doesn't get included in the path-changing PR at all.
The text was updated successfully, but these errors were encountered:
ShamrockLee
changed the title
[Feture Request] Validate CODEOWNERS file programmatically across path changes
Validate CODEOWNERS file programmatically across path changes
Nov 3, 2023
Issue description
There's currently no automatical ways to validate the paths inside the
CODEOWNERS
file. When files or directories are renamed, the path patterns may become invalid, but the error would be ignored silently across the PR review, unless the author found it during search/replace or when it is pointed out by a reviewers. It is very likely that no one ever thought about that file, and it doesn't get included in the path-changing PR at all.I encountered this issue when working on #262648.
Steps to reproduce
CODEOWNERS
.CODEOWENRS
referencing the changed path, to make the build passes.nixpkgs-review rev HEAD
, and make sure there's no unrelated problems.CODEOWNERS
path invalidation silently passes all the test cases.Technical details
"x86_64-linux"
Linux 6.1.55, NixOS, 23.05 (Stoat), 23.05.20231007.5a237ae
yes
yes
nix-env (Nix) 2.15.2
/nix/store/3fdrwsy2yi8rwxqylpd6vi2asraxq1nv-source
The text was updated successfully, but these errors were encountered: