Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/webhook: unable to use sockets #361568

Open
AndrewKvalheim opened this issue Dec 3, 2024 · 0 comments
Open

nixos/webhook: unable to use sockets #361568

AndrewKvalheim opened this issue Dec 3, 2024 · 0 comments
Labels
0.kind: bug Something is broken

Comments

@AndrewKvalheim
Copy link
Contributor

AndrewKvalheim commented Dec 3, 2024

Describe the bug

The recent update to pkgs.webhook included:

  • Add option to bind to a Unix socket instead of a TCP port (#703)
  • Add support for systemd socket activation (#704)

but services.webhook doesn’t expose any way to use this.

Expected behavior

  • Some way to specify -socket instead of -ip and -port
  • The generated systemd.services.webhook.script should be compatible with socket activation

Additional context

Reference: Using systemd socket activation

Metadata

$ nix-shell --packages 'nix-info' --run 'nix-info --markdown'
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.63, NixOS, 24.11 (Vicuna), 24.11.710194.f9f0d5c5380b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.10`
 - channels(root): `"nixos-24.11, nixos-hardware, unstable"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Notify maintainers

@W95Psp @ncfavier @azahi


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@AndrewKvalheim AndrewKvalheim added the 0.kind: bug Something is broken label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

1 participant