Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't write raw yaml #5

Open
michaelglass opened this issue Jul 4, 2016 · 1 comment
Open

don't write raw yaml #5

michaelglass opened this issue Jul 4, 2016 · 1 comment

Comments

@michaelglass
Copy link
Contributor

migrated from https://github.com/NoRedInk/NoRedInk/issues/11899

We should use the yaml library to export yaml instead of writing raw yaml. Writing raw yaml makes the code susceptible to a bunch of types of bugs (Escaping yaml primitives, etc) that using the library saves us from.

@BrianHicks
Copy link

BrianHicks commented Aug 23, 2021

This just bit us with a next-line (\u0085) character! So this bug is no longer hypothetical; even if it took a bit over four years to surface. Info about this character: https://www.unicode.org/standard/reports/tr13/tr13-5.html#Definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants