Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking as watch later shouldn't delete historical WatchAction data #35

Open
josephguillaume opened this issue Aug 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@josephguillaume
Copy link

This is more of a long term comment regarding the data model used.

If a movie has watch actions registered, selecting "watch later" deletes that data.
This means that information about when the movie was previously watched gets deleted.

It seems it would be more appropriate to instead add data indicating that the user wishes to watch it again.

One option would be to create a new watch action with
schema:actionStatus schema:PotentialActionStatus
If this option was used, it would make sense to consider whether to also use ActiveActionStatus, CompletedActionStatus, and/or FailedActionStatus.
Marking as watched would probably involve a WatchAction with CompletedActionStatus.

As a side issue, it appears that dc:createdAt, schema:startTime and schema:endTime currently all get set, and to the same time.
It would make sense to only set createdAt by default, and ensure that if data is set for start time and end time, it actually does refer to valid information about the start and end time of the user's watch action.

@NoelDeMartin
Copy link
Owner

Hey, thanks again for reporting an issue :D.

This behavior is something I implemented on purpose, given that with the current conceptual model a movie can only be "watched" or "pending". However, I have come across this use case myself and it is frustrating, so I was thinking on implementing the ability to rewatch movies (and also keep track of how many times you've watched a movie). I hadn't thought about it too much, but I like your proposal of using the actionStatus, so I'll keep it in mind.

About the timestamps, since the WatchAction was only created or destroyed, I was just setting the same date to all. But if I start creating actions before watching the movie, and use the actionStatus, I'll have to think about those. Thanks for the heads up.

@NoelDeMartin NoelDeMartin added the enhancement New feature or request label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants