We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another very minor issue that I'm sharing for completeness, sorry! Feel free to close as won't fix.
The code for parseRootDomain assumes a two part root domain
media-kraken/src/utils/Url.ts
Line 59 in 26c0943
This breaks down e.g. for externalUrls with country TLD e.g. https://www.sbs.com.au/ondemand/movie/ten-canoes/11858499617 renders as "view at com.au" https://iview.abc.net.au/show/imitation-game renders as "view at net.au"
A general solution seems non-trivial, but here's one that would be a relatively minor adjustment https://github.com/capturr/get-root-domain/blob/main/src/index.ts
The text was updated successfully, but these errors were encountered:
Hm yeah, that definitely looks like a bug, I'll look into it next time I work on the project. Thanks for opening an issue :).
Sorry, something went wrong.
No branches or pull requests
Another very minor issue that I'm sharing for completeness, sorry!
Feel free to close as won't fix.
The code for parseRootDomain assumes a two part root domain
media-kraken/src/utils/Url.ts
Line 59 in 26c0943
This breaks down e.g. for externalUrls with country TLD
e.g.
https://www.sbs.com.au/ondemand/movie/ten-canoes/11858499617 renders as "view at com.au"
https://iview.abc.net.au/show/imitation-game renders as "view at net.au"
A general solution seems non-trivial, but here's one that would be a relatively minor adjustment
https://github.com/capturr/get-root-domain/blob/main/src/index.ts
The text was updated successfully, but these errors were encountered: