Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hybrid foundry + hardhat is missing go to navigation when used with hardhat-foundry plugin #543

Closed
kanej opened this issue Feb 15, 2024 · 2 comments
Labels
foundry status:ready This issue is ready to be worked on

Comments

@kanej
Copy link
Member

kanej commented Feb 15, 2024

Reported on discord: https://discord.com/channels/750408878008827925/951537942239797338/1207246837237420032

Hello, i'm trying to set up a hybrid hardhat/foundry project but stuff like go to definition quits working when foundry is set up. When i comment out hardhat-foundry in hardhat.config.ts everything works again... Is there any solution to this?

A hybrid Hardhat + Foundry should support go to navigation and other features dependent on static analysis of the project; particularly if used with the hardhat-foundry plugin on the Hardhat side.

Reproduction steps

  1. Init a new Hardhat project
  2. Initialize foundry
  3. Add hardhat-foundry as a plugin, confirm compilation works from HH
  4. Attempt navigation within the vscode extension (it should not work). Comment out the hardhat-foundry plugin. Restart vscode and attempt navigation (it should work)

See the minimal reproduction in this repo: https://github.com/69ren/Hardhat-Foundry-test

In the vscode extension we differentiate between HH projects, Foundry projects, HH + Foundry hybrid projects. We should investigate whether the presence of hardhat-foundry is being taken into account in the project calculation i.e. is a hybrid HH + foundry project with hardhat-foundry really included better approached as a pure HH project from the extensions point of view for static analysis?.

@kanej kanej added status:ready This issue is ready to be worked on foundry and removed status:triaging labels Jul 29, 2024
@fvictorio
Copy link
Member

Is this a duplicate of #571?

@kanej
Copy link
Member Author

kanej commented Sep 16, 2024

Agreed, closing in favour of #571

@kanej kanej closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foundry status:ready This issue is ready to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants