Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just say no to CSV #244

Open
lars-t-hansen opened this issue Feb 3, 2025 · 1 comment
Open

Just say no to CSV #244

lars-t-hansen opened this issue Feb 3, 2025 · 1 comment
Labels
enhancement New feature or request Later Low priority / background task

Comments

@lars-t-hansen
Copy link
Collaborator

The JSON encoding of sonar ps data on a Fox login node is nearly 40% smaller than the CSV encoding (b/c records do not carry redundant version, timestamp and hostname for every record, and b/c the hostname is fairly long on the login node). When I looked at these data the other day I got this reversed: I thought the CSV was smaller.

[ec-larstha@login-3 sonar-main]$ target/debug/sonar ps --exclude-system-jobs --load | wc
    614     646   94470
[ec-larstha@login-3 sonar-main]$ target/debug/sonar ps --exclude-system-jobs --load --json | wc
      1      33   59042

Obviously if we really care about data size we'll use some binary encoding or make sure that data are compressed somehow for transmission, ideally very cheaply.

@lars-t-hansen lars-t-hansen added enhancement New feature or request Later Low priority / background task labels Feb 3, 2025
@bast
Copy link
Member

bast commented Feb 10, 2025

You make a good point that we should drop CSV in favor of JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Later Low priority / background task
Projects
None yet
Development

No branches or pull requests

2 participants