Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaflet should be a Peer Dependency #110

Open
leesei opened this issue Apr 22, 2016 · 4 comments
Open

Leaflet should be a Peer Dependency #110

leesei opened this issue Apr 22, 2016 · 4 comments

Comments

@leesei
Copy link

leesei commented Apr 22, 2016

I believe Leaflet should be a Peer Dependency.

@robpvn
Copy link
Contributor

robpvn commented Apr 26, 2016

That sounds like a good idea to me!

@robpvn
Copy link
Contributor

robpvn commented Sep 20, 2016

OK, so we merged a half-way fix to this by making leaflet a dev dependency, but this might be even better. @w8r, do you have thoughts on this? Want to implement it?

@w8r
Copy link
Contributor

w8r commented Sep 20, 2016

My solution with the plugins I maintain was first to have 2 versions in separate branches, one for 0.7, one for 1.0.x, and publishing to different tags, latest and rc or dev. But then with 1.0 release candidates popping out too often and not being handled correctly by semver, since they are custom suffixes, I grew rather tired and removed leaflet from dependencies and put it into devDependencies. peerDependencies didn't make it any easier, they just throw more warnings with version conflicts (see above about the custom version suffixes). So for the time being for the 1.0 plugins I only have leaflet as a devDependency, until the major version is finally published. That's what I proposed in #116 PR

Thanks for considering my opinion!

@sroucheray
Copy link

Leaflet 1.0 is out now !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants