Skip to content
This repository has been archived by the owner on Nov 26, 2021. It is now read-only.

Username blacklist #45

Open
geeksareforlife opened this issue Aug 21, 2013 · 4 comments
Open

Username blacklist #45

geeksareforlife opened this issue Aug 21, 2013 · 4 comments

Comments

@geeksareforlife
Copy link
Member

HMS is going to be hooked up to more and more systems. Users shouldn't be able to pick certain usernames (like "root"). The other systems should prevent problems as well.

Could be implemented as a simple text list, or a db table

@Pyroka
Copy link
Contributor

Pyroka commented Aug 21, 2013

Best idea is a db, then you can easily add it as a validation rule for the
model

On 21 August 2013 20:54, James Hayward [email protected] wrote:

HMS is going to be hooked up to more and more systems. Users shouldn't be
able to pick certain usernames (like "root"). The other systems should
prevent problems as well.

Could be implemented as a simple text list, or a db table


Reply to this email directly or view it on GitHubhttps://github.com//issues/45
.

@daniel1111
Copy link
Member

Yes, I think a table is definitely best. I think along with the obvious ones (root, admin, etc), we'll also want to populate it with all current wiki usernames?

@geeksareforlife
Copy link
Member Author

That's the plan. It came from you hooking it up to Jarvis (so root would be fun), but that got me thinking about the wiki - my username on there is different to my HMS one, and someone on HMS has my wiki username!

@daniel1111
Copy link
Member

Well, if you were to sign up as 'root', you simply wouldn't be able to connect to jarvis (wrong uid basically), which would serve you right

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants