Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: update JSONX.parse() to reject proto keys #16

Open
jasonswearingen opened this issue Apr 17, 2019 · 0 comments
Open

security: update JSONX.parse() to reject proto keys #16

jasonswearingen opened this issue Apr 17, 2019 · 0 comments
Labels
Milestone

Comments

@jasonswearingen
Copy link
Contributor

as shown here, json.parse() has exploit possibility: https://github.com/hapijs/bourne

either use bourne or port it's proto inspection regex into our jsonx util

this security issue isn't exploitable by default. it requires mallicious user input to be parsed and then assigned via object.assign() for the payload to become activated. This isn't a super common workflow, but This proposed fix would make the risk moot.

@jasonswearingen jasonswearingen added this to the vNext milestone Apr 17, 2019
@jasonswearingen jasonswearingen modified the milestones: vNext, vAfterNext Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant