Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename usages with legacy NBT naming #198

Closed
haykam821 opened this issue Jan 7, 2022 · 1 comment
Closed

Rename usages with legacy NBT naming #198

haykam821 opened this issue Jan 7, 2022 · 1 comment
Labels
breaking change
Milestone
0.6.0

Comments

@haykam821
Copy link
Contributor

FabricMC/yarn#2090 changed most NBT names, but Plasmid did not update some names accordingly:

  • ScoreStorage methods (toTag/fromTag)
  • Map packet documentation
  • Various locals and parameters
Shnupbups added a commit to Shnupbups/plasmid that referenced this issue Jan 8, 2022
@Shnupbups
NBT Renames
ad2ac7e 
Resolves NucleoidMC#198
Note: some things need to be renamed in Map Templates
@Shnupbups Shnupbups mentioned this issue Jan 8, 2022
Closed
@Patbox Patbox added this to the 0.6.0 milestone Apr 13, 2022
@haykam821
Copy link
Contributor Author

The API no longer contains legacy NBT names, so this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

NBT Renames Shnupbups/plasmid
2 participants
@haykam821 @Patbox