-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to version 18.0 #1364
Comments
We need to take some important decisions before we start the migration to v18. One of the big decision is about the introduction of the notion of payment mode in the "account" module via this commit: If we decide to use account.payment.method.line as a replacement of account.payment.mode, it implies that the separation between account_payment_mode and account_payment_partner doesn't make sense any more. And of course, the module name account_payment_mode would not make real sense any more. I see 2 options:
I also noticed that Odoo dropped account_journal_payment_debit_account_id and account_journal_payment_credit_account_id on res.company. They removed those fields in this commit "[IMP] account: make journal entry optional for payments" |
@alexis-via I would welcome the effort to homogenize the payment mode module with new standard logic. |
Thanks for raising this subject. About the module replacing And for the final question about the "no journal entry for account.payment"... I would say we should follow, unless we have strong arguments for not doing it? |
Notes for me meanwhile I inspect deeper: Related Odoo patch: odoo/odoo#182390 |
I wish I had more answers on my proposals... Let's go with a new module "account_payment_base_oca" to replace account_payment_mode and account_payment_partner ! |
Please wait till Thursday and I'll answer |
I have sped up the checking of this for having an answer ASAP. About replacing account.payment.mode with account.payment.method.line, for me is a total no. This model doesn't reflect the real need of users, which is to annotate the payment instrument. Instead, they put a field where you see several times the same payment method, one per journal: You may know that you want SEPA CT, but not yet with which bank (or yes, but not defined at partner level). For me it's totally misleading, and users will complain with the change. And what happen if you change your bank account? You are forced to change this data in all your partners. It's a nonsense. We should keep About the entry creation on payments, I already pointed to odoo/odoo#182390, which is forcing to create them in community (not having the enterprise accounting module installed), which is an ugly patch, but it serves to us. I think there's nothing to do, except declare |
Todo
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
Modules to migrate
Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list
The text was updated successfully, but these errors were encountered: