Migration to version 18.0

[OCA-git-bot]

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Modules to migrate

• account_einvoice_generate
• account_invoice_facturx
• base_business_document_import
• base_edi - By @JordiMForgeFlow - [18.0][MIG] base_edi #1055
• base_facturx
• base_import_pdf_by_template
• edi_voxel_account_invoice_oca
• edi_voxel_oca
• pdf_helper
• test_base_import_pdf_by_template

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

[alexis-via]

I'm facing a problem while migrating account_invoice_facturx from v17 to v18: in v18, a new field is_invoice_report was added to ir.actions.report and the method _is_invoice_report(report_ref) was updated to use that new field:
odoo/odoo@bb60952

The problem is that, by default, is_invoice_report is True on report "Invoices" (XMLID account.account_invoices) but it is False in report "Invoices without Payment" (XMLID account.account_invoices_without_payment)

In another commit, the report "Invoices" which has is_invoice_report=True was renamed to PDF and removed from the print menu, cf:
odoo/odoo@73c9fb4#diff-3b18ee604f9c7367c3d380bcc92f09c390e896f511bbe563f19116297a8ab653

So, if we continue to use the method _is_invoice_report(report_ref) to choose if we should attach the file factur-x.xml or not, the PDF retreived from the print menu will not have the XML attachment.

Here are the options we have:

1. in the post-install script of account_einvoice_generate (for example), we set is_invoice_report to True on report "PDF without Payment" (XMLID account.account_invoices_without_payment). Advantage: the user can always switch back to native behavior by changing the value of that field)
2. we stop using _is_invoice_report(report_ref) and switch back to an OCA method like we used to do in the past
3. we think there is a really good reason to consider that the invoice retreived from the print menu should not be a factur-x invoice (I don't see any... but you may have a different opinion)

For the moment, I plan to implement option 1. Please give your opinion on this before we take the final decision.