From 9e5524852fd46f4f3e8ab8981200e5bb7019b30a Mon Sep 17 00:00:00 2001 From: Dario Del Zozzo Date: Thu, 16 Feb 2023 12:51:02 +0100 Subject: [PATCH] [FIX] hr_holidays_public: fixed action_validate() override --- hr_holidays_public/models/hr_leave.py | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hr_holidays_public/models/hr_leave.py b/hr_holidays_public/models/hr_leave.py index a31da0e5..5b4ba8e7 100644 --- a/hr_holidays_public/models/hr_leave.py +++ b/hr_holidays_public/models/hr_leave.py @@ -13,11 +13,16 @@ def action_validate(self): actions derived from this validation. This is required for example for `project_timesheet_holidays` for not generating the timesheet on the public holiday. Unfortunately, no regression test can be added, being in a separate module.""" - if self.holiday_status_id.exclude_public_holidays or not self.holiday_status_id: - self = self.with_context( - employee_id=self.employee_id.id, exclude_public_holidays=True - ) - return super(HrLeave, self).action_validate() + for leave in self: + if ( + leave.holiday_status_id.exclude_public_holidays + or not leave.holiday_status_id + ): + leave = leave.with_context( + employee_id=leave.employee_id.id, exclude_public_holidays=True + ) + super(HrLeave, leave).action_validate() + return True def _get_number_of_days(self, date_from, date_to, employee_id): if self.holiday_status_id.exclude_public_holidays or not self.holiday_status_id: