Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] remove OCA_PROJECTS dictionary #410

Open
sbidoul opened this issue Mar 11, 2019 · 5 comments
Open

[RFC] remove OCA_PROJECTS dictionary #410

sbidoul opened this issue Mar 11, 2019 · 5 comments

Comments

@sbidoul
Copy link
Member

sbidoul commented Mar 11, 2019

Soon, the reference data for which PSC is in charge of which repo will be in the odoo-community.org database.

I therefore propose to drop the hard coded dictionary in tools/oca_projects.py.

@pedrobaeza
Copy link
Member

Well, it's still used in some tools in OCA/maintainer-tools, and connecting to OCA instance is not something feasible.

@sbidoul
Copy link
Member Author

sbidoul commented Mar 11, 2019

@pedrobaeza which tools are you referring to? I see only check_contrib which is old and most probably never unused. It's also easy to adapt.

I've personally never been in a situation where using this list without being connected to GitHub was really necessary.

I want to progressively simplify the repo creation process, and this is one of the steps that we could remove.

@pedrobaeza
Copy link
Member

Last PR for publishing modules is based on it for example: #409

But OCA bot also uses it:

for repo, branch in get_repositories_and_branches(repos, branches):

@sbidoul
Copy link
Member Author

sbidoul commented Mar 11, 2019

That is fine. I don't want to kill oca_project.py, I want to kill the hard-coded OCA_PROEJCTS constant in it.

@pedrobaeza
Copy link
Member

OK, then I think we can strip it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants