From 498e0f9590739d78ebac6bff2e370fa86e1cb9ee Mon Sep 17 00:00:00 2001 From: "Matias N. Goldberg" Date: Sat, 7 Dec 2024 11:54:21 -0300 Subject: [PATCH] [Vk] Fix warnings "delete called on non-final 'Ogre::VulkanCache' that has virtual functions but non-virtual destructor." This was introduced due to deriving from VulkanDeviceResource for device lost handling. --- RenderSystems/Vulkan/include/OgreVulkanCache.h | 2 +- RenderSystems/Vulkan/include/OgreVulkanDiscardBufferManager.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/RenderSystems/Vulkan/include/OgreVulkanCache.h b/RenderSystems/Vulkan/include/OgreVulkanCache.h index 09c8d75a03..973c296319 100644 --- a/RenderSystems/Vulkan/include/OgreVulkanCache.h +++ b/RenderSystems/Vulkan/include/OgreVulkanCache.h @@ -39,7 +39,7 @@ namespace Ogre { /** */ - class _OgreVulkanExport VulkanCache : public OgreAllocatedObj, protected VulkanDeviceResource + class _OgreVulkanExport VulkanCache final : public OgreAllocatedObj, protected VulkanDeviceResource { protected: struct VkRenderPassCreateInfoCmp diff --git a/RenderSystems/Vulkan/include/OgreVulkanDiscardBufferManager.h b/RenderSystems/Vulkan/include/OgreVulkanDiscardBufferManager.h index 292be10149..7097b7ac35 100644 --- a/RenderSystems/Vulkan/include/OgreVulkanDiscardBufferManager.h +++ b/RenderSystems/Vulkan/include/OgreVulkanDiscardBufferManager.h @@ -45,8 +45,8 @@ namespace Ogre /// /// We need Discard for the v1 interfaces. So we need to emulate it. /// This class does exactly this. - class _OgreVulkanExport VulkanDiscardBufferManager : public OgreAllocatedObj, - protected VulkanDeviceResource + class _OgreVulkanExport VulkanDiscardBufferManager final : public OgreAllocatedObj, + protected VulkanDeviceResource { public: struct UnsafeBlock : public VulkanVaoManager::Block