-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is still Ubuntu 16.04 the suggested distro to build ? #807
Comments
Hello @adriangibanelbtactic, you are right, i got the same error. I created ticket #68017 |
build_tools base repo version: similar issue at building v8
Due to need of python3.8 |
It's fixed at c9de527 and will be released in next major release. @adriangibanelbtactic and @shooding thank you for the detailed report. |
Thank you very much @igwyd ! BTW, don't forget about the https://github.com/ONLYOFFICE/document-server-package/ repo. Thank you again. |
@igwyd release/v8.1.0 still gets error when building v8 and cipd
|
Wait a moment... that commit has a python3.tar.gz binary. I mean... that python3.tar.gz's python3/bin/python3.10 binary might have a trojan after all. There should be another fix that does not end up throwing a binary on the repo. Thank you for considering an alternative. |
@shooding, I cheked branch release/v8.1.0 4 days ago in docker 16.04 this error is gone, but branch release/v8.1.0 still in development and other error may appear. @adriangibanelbtactic I think it's about trust to this repo, you are you are an experienced user and you can check binary files or replase it. |
Struggling for several days build for v7.5.1 [OK] serveral months ago. build for v8.0.1 [FAILED] Several common issues like:
After all those fails l tried to update Dockerfile and automate.py "--update", "0" and In the updated Dockerfile pre-installed Even though tried configure.py with "--update", "0", still get error 1 when building core common modules like boost or v8. |
I've managed to with several speed up techniques allow you to continue the build. Here's the Dockerfile that pre-install openjdk. You can omit this if network is very stable. Also change sources.list to the one closet helps.
export VERSION=8.0.1
cd build_tools && docker build -t documentserver-develop:$VERSION . Note that i mounted ssh key into container so that we can force using ssh protocol to avoid "RPC failed; curl 18 transfer closed with outstanding read data remaining container" with unstable network (e.g. WiFi congestion). docker run -it --platform=linux/amd64 -p 80:80 \
-e PRODUCT_VERSION=$VERSION \
-e BUILD_NUMBER=50 \
-v ~/.ssh:/root/.ssh \
-v $WORKFOLDER:/work \
documentserver-develop:$VERSION You'll enter the container then copy & paste these command to have smooth cloning process. git config --global url."[email protected]:".insteadOf "https://github.com/" && ssh-keyscan github.com >> /root/.ssh/known_hosts && eval "$(ssh-agent -s)" && ssh-add /root/.ssh/id_rsa If you github ssh key is encrypted, here you enter password. In my senario, i just want to change some stuff in sdjks and web-apps, therefore building
You can check the function def get_repositories() in def get_repositories():
result = {}
# result["core"] = [False, False]
# result["sdkjs"] = [False, False]
result.update(get_sdkjs_addons())
result["onlyoffice.github.io"] = [False, False]
# result["web-apps"] = [False, False]
result.update(get_web_apps_addons())
# result["dictionaries"] = [False, False]
# result["core-fonts"] = [False, False] Why need to comment out manually? while Then i ran with cd build_tools/tools/linux/ && python3 ./automate.py server Build [OK] |
Sorry, we forgot to mention that issue was fixed. |
I've been trying to build onlyoffice bu just cant find a branch where this is posiible. You say this is fixed, on which branch/tag/master can you build onlyoffice according to the build tools instruction with the supplied Dockerfile? Ubunut16.04 doesn't have python 3.6 so that can't be used anymore but that is still in your files.. |
Hello @Nocodemon it was fixed in th v8.1.0, python3.6 added to the build_tools. You can build it from the master branch using docker for example. |
I don't think this is true, I just did now and the problem with depot_tools is still there. /cipd: line 143: ./depot_tools/cipd_client_version.digests: No such file or directory Config file location Action Type Other v8 (ERROR)[0:00:00] Started.Traceback (most recent call last): |
Yes i was using docker (documentserver-develop tag) to build, which is from ubuntu:16.04 and the environment is more fixed. |
@shooding you mind sharing exactly how you do it? I'm on Ubuntu 20.04, please share how you git checkout and then the build and run code. Because it feels like I've tried every branch and never gets through building v8 |
I tried to build on Ubuntu 20.04 before and will encounter python version
issue and packages installed via apt-get didn't fully matches with Ubuntu
16.04. Therefore i am using docker to build it.
You can clone the build_tools git and read through README.md under develop
folder.
docker build the builder image (16.04) first then run container to build
it.
Make sure your network speed stable and fast because many 3rd party repo
are cloned during the build.
Follow instructions until ./automate.py server
I think the largest steps are building for qt 5.9.9 and v8
Nocodemon ***@***.***> 於 2024年9月19日 週四 20:06 寫道:
… @shooding <https://github.com/shooding> you mind sharing exactly how you
do it? I'm on Ubuntu 20.04, please share how you git checkout and then the
build and run code. Because it feels like I've tried every branch and never
gets through building v8
—
Reply to this email directly, view it on GitHub
<#807 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQKSNWWH4KS7GAHKHGHOU3ZXK45NAVCNFSM6AAAAABHLJAYWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRQHAYDSOJRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ok, so I reinstalled docker according to the stuff in develop and set it up so it doesn't need to run with sudo. Master branch still fails. You say you run 8.1.3.3 do you just do git checkout 8.1.3.3 and then run it with
|
Tried checking out the develop branch and 8.1.1.3 but that also generates errors and stops. `In file included from ../../src/base/logging.h:21: I'll try and check out 8.1.3.3 from the master branch and build that as well |
master 8.1.1.3 also has the depot_tools error
|
I've the same issue, did you mange to get it working? |
Platform linux-amd64 is not supported by the CIPD client Some advice
Why?
It might be python after allMy first encounter to this error was related to python3 not being installed which they might have fixed by adding a binary of python3. It might that that enforced binary does not work for your system properly because of... how it was built in the first place. FeedbackPlease tell us what you find out. That way onlyoffice community will know how to address these |
Hi, Thank you for this. I ran some tests and added the reinstall command to /tools/linux/deps.py, but that wasn’t enough. So, I included the Node.js installation in the Docker file, which resolved that issue. However, we're now back to the previous error. I’ve applied the linux_amd64 fix, as you have in your Git repository: I’m still encountering the same issue. It feels like the developers from ONLYOFFICE don’t use this compiler themselves. Even after these changes, I’m still encountering the same issue. It's also funny that they rename it as linux-amd64 when the correct format is linux_amd64. I've never heard anyone use a hyphen ("-") instead of an underscore ("_"). This error are still there even after the changes:
|
But isn't the .cipd error actually just the fact that .depot_tools isn't located at ./depot_tools. And they can't find that file? |
I have tested it with almost everything I can think of: Used an Intel CPU instead of an AMD CPU. However, isn’t the .cipd error simply because .depot_tools isn’t located in ./depot_tools? Is that why it can’t find the file? When I search inside Docker, I can see the file, so it seems there’s an issue with the compiler that isn't working as expected. |
I think you guys should ignore this commit as it doesnt do anything. i added to try my luck before and forgot to remove it. :D Btw did you try to compile everything or just server? Make sure to just run
|
Server and web-apps. |
I dont think you need to specify "web-apps". Specify "server" it will include "web-apps". |
unfortunately same error occur even if i add "./automate.py server"
|
I confirm that v8.1.3.3 version can be built thanks to the default Docker. I am writing a how-to so that you can use it thanks to my usual patches in order to build your custom version of OnlyOffice. That way you will know how to build newer versions as @razerrazer asked me. Stay tuned! |
@adriangibanelbtactic I believe the compiler is working now. I switched to using the dev build of build_tools, and the code seems to have compiled successfully (at least, as far as I can tell). I now have files in the out folder inside build_tools, but they might still have issues with their own build_tools. |
@adriangibanelbtactic An How-to would be awesome :) @razerrazer are you saying you can check out the offical onlyoffice developer branch and everything will work with the supplied Dockerfile? |
Here there's the thing:
So when build time comes I make sure to:
and hope for the best. And if it does not build I try it again from scratch once more just in case it was a temporarily Internet connection issue. P.S.: I will add an adaptation of this wall of text to my big how-to build VPS preparation section. :) |
Sorry, you're right. I will provide everything I did here so it might help others. I used Ubuntu version 22.04 and Debian 12, and I’ve tried this on both an Intel CPU and an AMD CPU. First, I encountered the exact same issue as you in the initial step. I’m using a machine with 64 cores and 64 GB of RAM for this compilation, so hardware isn't the problem. I also have a good fiber connection with no packet loss and a stable connection. Here’s what I did:
But I got this error:
I followed some suggestions made by others in this thread, modified Dockerfiles, etc., but the same thing kept happening. So, I decided to try something else. I tried using @adriangibanelbtactic’s build_tools, which is almost 3 years old, and that one worked. This led me to think that the issue might be in the current code, which was my initial suspicion. Then I discovered that OnlyOffice has a developer branch of build_tools, so I tried that one. The only change I had to make was adding this line to my Dockerfile:
because it still complained that the Node.js version couldn't be less than 16. Here’s my Dockerfile if anyone wants to try it themselves:
To be able to test the developer branch you need to do the following steps:
I can’t guarantee this will work, but I can see files located in the out directory:
I will test this code later today, but I think it should work. |
No wonder you had an error.
You were mixing desired version (8.1.1.3) and tags being used (8.0.1.31). |
@razerrazer Thanks, I'll try your Dockerfile but trying with 8.1.3.3 since that is the latest. and hoping you just didn't find a buildable branch 8.1.1.3 by accident :) |
It was a typo. I just added what I remembered, so in this way I can ensure that I use the right version every time I compile. |
It was a typo, i just copy what was in here and change the numbers, I can ensure that it is with the right version 8.1.3.3 :) i also edited my previous post. |
So close!
@razerrazer what do you mean by run the installation from the current build_tools (check with git checkout). after you checked out the develop branch, you want med to do a git checkout develop just to make sure i'm on that branch? |
Yes, it's just to make sure you're on the correct branch. However, if you use the '-b' option, it will download the correct branch for you. This is just so you can double-check that you are on the right branch. It was not my intention to make things more complicated! |
Another example of mixing versions all around:
|
I'll be honest with you, since this build_tools doesn't work with Ubuntu 22.04 or Debian 12, this is a solution, even though a development build might not be the best choice here. However, it works.
Please check my repository. I don't use any mix of development tools for web apps, servers, or anything like that—just for the build_tools, nothing else. |
Well, I'm a bit lost with what you wrote in #807 (comment) where you seemed to be using Ubuntu 16.04 from inside the docker container. Now, it seems different than that. Are you building it in ubuntu 22.04 o Debian 12 instead?
Apparently the only difference with my own changes to your v8.1.3.3-razerrazer tag is that I don't need to make any changes to the Dockerfile file. Unless you are building outside of the docker or with one of those setups where ipv6 is turned on I don't know why it's a problem for you. |
When I say I'm using Ubuntu 22.04 or Debian 12, I just mean the base OS I use for the compilation. However, the Dockerfile is still based on Ubuntu 16.04. I hope this gives you more context. For example, if I use the current main build_tools from OnlyOffice, the compiler doesn't work at all. But with the developer branch, it does. |
Once you make sure to use Docker-CE and not some substitutes like podman from RHEL distros you are good to go. The base OS where docker is installed shouldn't matter in most of the cases.
I already pointed to this issue in my wall of text:
You were using the main branch because some of the documentation points you there. Regarding using develop branch, well, that's not a good piece of advice because it's being used to develop v8.2.x which might be similar enough to v8.1.x but in the future it might break the build for v8.1.x. |
@adriangibanelbtactic how is your how-to going. Are you saying that v8.1.3.3 is buildable in the master branch? Because I think noone has gotten past the v8 error with the original build_tools? |
85% complete. I am working on it a bit every day. It should be ready in two or three more days.
No, I'm not saying that. What I'm saying is:
Or in other words if you plan to build v8.1.3.3:
|
Either install Ubuntu 16.04 in a VPS or use Github Actions (more details on my future how-to) where using docker is allowed. Extra: I managed to build Any other OnlyOffice version with a different Ubuntu version with an actual installation (no docker) ? Who knows... That's not officially supported. The only supported build is based on Ubuntu 16.04. |
@adriangibanelbtactic Nice :) I'm building in docker I just can't run the docker container version in production. I need the files so I can build my own rpm. I managed to build the server now. I entered the container after it cloned the wrong repo of web-apps and cloned the delevop one instead. But I also noted that the build is very different from the masterbranch and is half the size. And it seems to not be functional, I get everything to run but it won't open my docs. ( still need to verify if something changed between 8.1.1 and 8.1.3 ) |
Are you able to do this with the current master build of build_tools? I ask because it does not work at all for me, so i have to use the developer build to be able to do the compilations. |
No, I haven't even tried it. Why would I do so in the first place? |
Hopefully this how-to suits most of you and we can move the discussion out of here where actual issues should be reported thanks to new issues and not updating an old issue which was already marked as solved. |
As I have already reported in #802 (comment) builds from Docker (which uses Ubuntu 16.04) seem to fail.
It probably arises from a depot_tools repo commit from April (one month ago) which forces you to use Python 3.6 or a newer version.
I was wondering if, as it has already happened in the past OnlyOffice is built internally with some other dependencies and the Github repo is not updated yet.
I suspect that now internal builds are based on Ubuntu 20.04.
In that case both the README and the Dockerfile should be updated.
Steps to reproduce the problem:
build_tools base repo version:
v8.0.1.31
Operating system:
Ubuntu 16.04
Compiler version:
Whatever Dockerfile installs.
The text was updated successfully, but these errors were encountered: