From 685e1a30ead750bfc70c1e20c8a09d750911287d Mon Sep 17 00:00:00 2001 From: Sebastian Date: Fri, 13 Sep 2024 11:25:13 +0100 Subject: [PATCH 1/2] Add Pylint command to jinja template --- project_template/Makefile.jinja | 1 + 1 file changed, 1 insertion(+) diff --git a/project_template/Makefile.jinja b/project_template/Makefile.jinja index 85a9860..099cb48 100644 --- a/project_template/Makefile.jinja +++ b/project_template/Makefile.jinja @@ -24,6 +24,7 @@ format: ## Format the code. lint: ## Run all linters (black/ruff/pylint/mypy). {{ package_manager }} run black --check . {{ package_manager }} run ruff check . + {{ package_manager }} run pylint {{ module_name }} make mypy .PHONY: test From f4c7e0ec14bbd8565866ca0ef1ff6aab09e49185 Mon Sep 17 00:00:00 2001 From: Sebastian Date: Fri, 13 Sep 2024 11:55:46 +0100 Subject: [PATCH 2/2] Subsequent linters don't run After using the template on another repository, the ruff, pylint and mypy commands run but finish with an error that stops subsequent commands from running: make: *** [] Error --- project_template/Makefile.jinja | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/project_template/Makefile.jinja b/project_template/Makefile.jinja index 099cb48..fbaf81b 100644 --- a/project_template/Makefile.jinja +++ b/project_template/Makefile.jinja @@ -23,8 +23,8 @@ format: ## Format the code. .PHONY: lint lint: ## Run all linters (black/ruff/pylint/mypy). {{ package_manager }} run black --check . - {{ package_manager }} run ruff check . - {{ package_manager }} run pylint {{ module_name }} + {{ package_manager }} run ruff check . || true + {{ package_manager }} run pylint {{ module_name }} || true make mypy .PHONY: test