From fb6daa2ea4ef0616cade89e8f66d1b12011625fb Mon Sep 17 00:00:00 2001 From: Robin Karlsson Date: Wed, 21 Aug 2024 09:48:49 +0300 Subject: [PATCH] Explicitly close RemoteTransfer tempfile Prevents the Tempfile from staying around until garbage collection on error. --- apps/dashboard/app/models/remote_transfer.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/dashboard/app/models/remote_transfer.rb b/apps/dashboard/app/models/remote_transfer.rb index c824290279..2ad8b1c2eb 100644 --- a/apps/dashboard/app/models/remote_transfer.rb +++ b/apps/dashboard/app/models/remote_transfer.rb @@ -132,6 +132,7 @@ def perform errors.add :base, e.message ensure self.status = OodCore::Job::Status.new(state: :completed) + tempfile&.close(true) end def from