Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-set overrides previous cached values #4034

Open
johrstrom opened this issue Dec 23, 2024 · 1 comment
Open

data-set overrides previous cached values #4034

johrstrom opened this issue Dec 23, 2024 · 1 comment

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Dec 23, 2024

related to #2817 - Disclaimer that this may be tricky and/or is an indication that something needs reworked fundamentally.

data-set- directives currently override previous cached values in the form. Consider this form.yml. It says I can have a max of 4 GPUs.

cluster:
  - owens

form:
  - gpus
  - node_type
attributes:
  gpus:
    widget: number_field
    min: 0
    max: 4
  node_type:
    - ['gpu', data-set-gpus: 1]
    - ['cpu', data-set-gpus: 0]

Now if I Submit the job with a selection of 2 GPUs.

expected behavior

When I reload the page, it should have cached the choice of 2 GPUs.

actual behavior

The data-set directive sets the gpu field to 1.

@johrstrom johrstrom added this to the 4.1 milestone Dec 23, 2024
@johrstrom
Copy link
Contributor Author

I open this because as a user it would be very frustrating to always have to change the value of gpus to 2 even though the choice should have been cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant