Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usernames can be all numbers, not UIDs #4104

Closed
johrstrom opened this issue Jan 28, 2025 · 1 comment · Fixed by #4128
Closed

Usernames can be all numbers, not UIDs #4104

johrstrom opened this issue Jan 28, 2025 · 1 comment · Fixed by #4128
Assignees
@johrstrom
Milestone
4.0

Comments

@johrstrom
Copy link
Contributor

#3795 broke an unexpected use case: Usernames that are all numbers. So it seems like this needs to be behind some sort of feature flag so that sites with all numbers as usernames correctly work.

From discourse: https://discourse.openondemand.org/t/usernames-of-only-numbers-can-not-login-to-ood-4-worked-in-3-x/3992
@johrstrom johrstrom added this to the 4.0 milestone Jan 28, 2025
@johrstrom johrstrom self-assigned this Feb 5, 2025
@johrstrom johrstrom mentioned this issue Feb 6, 2025
Merged
@johrstrom
Copy link
Contributor Author

The fix is being backported to 4.0 in #4134, so it'll be shipped in 4.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johrstrom johrstrom

Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

account for numeric usernames OSC/ondemand
1 participant
@johrstrom