Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DdddWith simplicity comes limitations, like with most things. RSpec makes it easy to do complex stubbing (mocking) as well as support numerous kinds of matchers that read well. Also keeping tests from spilling into other tests is a huge benefit to RSpec. #855

Closed
253700ratchakon opened this issue Oct 1, 2024 · 1 comment

Comments

@253700ratchakon
Copy link

          With simplicity comes limitations, like with most things.  RSpec makes it easy to do complex stubbing (mocking) as well as support numerous kinds of matchers that read well.  Also keeping tests from spilling into other tests is a huge benefit to RSpec.

Before you fully commit to replacing RSpec, might be good to take one of two complex test cases from each RSpec file and make sure you can adequately replace them with minitest. Simplicity at the cost of functionality is not a good trade off. If minitest is going to make testing less reliable or function in a way that makes them less useful, that seems like a deal breaker.

Also the e2e tests in main OnDemand repo have to stay with Rspec cause there is simply no way to use minitest to replace beaker-rspec plugin.

Originally posted by @treydock in #844 (comment)

@johrstrom
Copy link
Contributor

Not sure why you opened this, if it was an accident or what, but we are indeed moving to minitest instead of rspec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants