Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: auto-start API crash when server already running #548

Open
JeroMiya opened this issue Jun 4, 2017 · 0 comments
Open

Android: auto-start API crash when server already running #548

JeroMiya opened this issue Jun 4, 2017 · 0 comments

Comments

@JeroMiya
Copy link
Contributor

JeroMiya commented Jun 4, 2017

Steps to reproduce:

  1. Run osvr_server from adb or OSVRServerLauncher app.
  2. Run the OSVROpenGL sample app, which uses the auto-start API to start in-process server.
  3. Note the exception escapes the C function.

Expected behavior: C function should log the failure (already does, with the right message) but otherwise fail silently. ClientKit will then connect to the already running server. Additionally, the shutdown function should not crash either (not tested prior to filing this issue, but test before closing this issue).

We probably are just missing an exception handler in the C API function. Should be no need to log the exception since the underlying implementation already logs the failure more specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant