Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Definition and non-Aristotelian Definitions #8

Open
CarterBeauBenson opened this issue Sep 2, 2023 · 3 comments
Open

Missing Definition and non-Aristotelian Definitions #8

CarterBeauBenson opened this issue Sep 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@CarterBeauBenson
Copy link

Describe the bug
Many classes are missing definitions. Some of the classes that do have definitions, like "soil or plant scientist" are non-Aristotelian, meaning they are not in the form "b is a c that d's" where b is the class defined, c is the parent class to which b belongs, and d is the differentiating feature from sibling classes.

Expected behavior
Add definitions where they are missing and correct non-Aristotelian definitions.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows
  • Browser: chrome
  • Version: 1.0.65

Additional context
I am John's research assistant. He asked me to look over the OWL file.

@CarterBeauBenson CarterBeauBenson added the bug Something isn't working label Sep 2, 2023
@zhengj2007
Copy link
Contributor

@CarterBeauBenson Thanks for pointing it out.

We are working on the definitions of terms. According to OBO dashboard checking, missing definition is warning rather than error. see: Robot report

@zhengj2007 zhengj2007 added enhancement New feature or request and removed bug Something isn't working labels Sep 8, 2023
@giacomodecolle
Copy link
Contributor

@zhengj2007 I have started working on making the skills and ability definitions into the Aristotelian format. What would be the best way to offer this as contribution, is it by modifying the .owl file? I remember you mentioned that you might have preferred another way of doing so.

@zhengj2007
Copy link
Contributor

@giacomodecolle I wrote a wiki page describing how to edit the OccO, https://github.com/Occupation-Ontology/OccO/wiki/OccO-Editing. Please feel free to contact me if you have any questions.

Besides, it's better to make the changes in a new branch and create pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants