Skip to content
This repository has been archived by the owner on Jan 21, 2021. It is now read-only.

Are these being updated? #64

Open
erbnate opened this issue Sep 3, 2019 · 4 comments
Open

Are these being updated? #64

erbnate opened this issue Sep 3, 2019 · 4 comments

Comments

@erbnate
Copy link

erbnate commented Sep 3, 2019

2-4 years average age, no new commits. Many problems with these scripts and MFA. Typical MS.

@PsychoData
Copy link

PsychoData commented Sep 16, 2019

@erbnate If you have 2FA enabled, then you should be using EXO PS Hybrid module to connect instead of the direct URL to connect. You can launch/download it here http://aka.ms/ExoPSHybrid (Clickonce Application, works best in IE or Firefox, or Chrome with a ClickOnce Extension)

Once that is loaded, run the rest of the scripts and they should work fine.

I haven't really found a good way to suggest importing the Hybrid Module directly that flows.

I have code that can import it into any PS Session, but not without bloating the scripts significantly or extracting the "Connect to exchange online" function out to a separate script.
In which case, the "Download and run this one ps1" capability is lost.

Thoughts/suggestions on how we could make this flow work smoothly?

@PixelP0w3r
Copy link

PixelP0w3r commented Apr 20, 2020

@erbnate I am as disappointed as you. These scripts are not written very well at all which is apparent by how often they are updated (rarely if ever), how many syntax errors get returned (too many), having hard-coded variables inside the script instead of parsing them in a temporary variable, not getting expected results, etc.

I ran this script with EXO PS Hybrid module and MSOnline. Both of them return a huge list of users which are obviously active. I get errors such as 'Search-UnifiedAuditLog' is not a cmdlet, function, script... By the way you can't even use EXO PS Hybrid module without IE (a deprecated browser) because OneClick extensions don't work in Firefox/Chrome without third party unsupported add-ons. You don't even need to use EXO Hybrid module if you use MFA safe IP list which should contain the IP's of your organization so users are never challenged for 2FA while at the office.

It's actually sad that Microsoft is referencing this github page to see inactive users for last 90 days when the script doesn't even work. It is referenced on Identity Secure Score page under remediation for [Delete/Block accounts not used in the last 30 days]

Ultimately I end up using this script here: https://gallery.technet.microsoft.com/office/Export-Office-365-Users-ae3463f2

It works like a charm, and will output a .csv containing User Principal Name, Display Name, Last Logon Time, Creation Time, Inactive Days, Mailbox Type, Assigned Licenses (Friendly Name), Admin Roles. Then I can further do data sorting and filtering in Excel to see just what I want to see.

@PsychoData
Copy link

For a while I was actually trying to keep an updated version of this repo in my forked copy, but MS never would merge any of the PR's back (aside from a few MS people's PR's merged in) so I gave up on it - would love for someone with access to handle these to take some action on them, and then I would even be happy to sink some time into it

Although, some of the things that a lot of people are asking about are easy fixes now with preview modules (Like a Install-Module available version of the Exchange Online module that supports MFA builtin, without have to get the .Application version for Exchange Hybrid to support MFA)

The worst part is that a lot of the PRs are simple things like fixing a few typos in commands or comments, but no one seems to want to work them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@PsychoData @erbnate @PixelP0w3r and others