Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - missing aria-label to prev and next links of is_imageslider #312

Closed
Maofree opened this issue Nov 1, 2023 · 2 comments
Closed
Labels
bug Something isn't working is_imageslider minor

Comments

@Maofree
Copy link

Maofree commented Nov 1, 2023

Description

Hi
google page speed alert me about an accessiblity problem about a text associated with the links of prev and next of is_imageslider module

normally to fix this type of error I use aria-label="Previous" and aria-label="Next"

1

Node.js version

v16

php version

8.1

OS and it's version

linux

Browsers

Chrome

Required module/theme

is_imageslider

Reproduction steps

1. look at the image or try a test with google page speed

Logs

No response

@Maofree Maofree added the bug Something isn't working label Nov 1, 2023
@Oksydan
Copy link
Owner

Oksydan commented Nov 3, 2023

Hi @Maofree,

thank you for creating an issue.
It's more like improvements instead of bug. I am going to fix it in next version of is_imageslider module.

@Oksydan
Copy link
Owner

Oksydan commented Jan 6, 2024

Hi @Maofree

this problem has been fixed here Oksydan/is_imageslider#50. It will be available in next major version.
Thank you for your contribution.

@Oksydan Oksydan closed this as completed Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working is_imageslider minor
Projects
None yet
Development

No branches or pull requests

2 participants