Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoding host ports is not recommended when using docker #279

Open
grodin opened this issue Jan 25, 2024 · 0 comments
Open

Hardcoding host ports is not recommended when using docker #279

grodin opened this issue Jan 25, 2024 · 0 comments
Labels
robustness Issues related to making the app more robust tech debt tests

Comments

@grodin
Copy link
Collaborator

grodin commented Jan 25, 2024

It's not recommended to hardcode the host ports that docker maps a container's ports to in order to avoid clashes with ports already in use. This shouldn't really matter on Github's CI due to the isolation, but it's still good practice.

This will require passing the ports into the test apk running on the emulator/device, which in turns needs a custom test runner (a subclass of AndroidJUnitRunner ). If started via adb shell am instrument, args can be passed and read by the subclass and used in the tests.

This is all quite involved and the integration tests are fine right now, so this is low priority, just for documentation's sake.

@grodin grodin added tests robustness Issues related to making the app more robust tech debt labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
robustness Issues related to making the app more robust tech debt tests
Projects
None yet
Development

No branches or pull requests

1 participant