Can Buy Blue Potion without Showing Odd Mushroom

[r0bd0g]

Only works if you have nothing in your trade slot.

I didn't have trade shuffle on and my starting item was randomly selected to be Pocket Egg. I'm not sure if this only occurs under specific settings combinations or not.

[r0bd0g]

Rob has this to say:

problem seems to be in this function:

uint32_t SaveFile_TradeItemIsTraded(uint16_t itemId) {
// Adult trade shuffle without full shuffle does not set traded flags
// because of timers. Some hacks still need to know if the item was
// traded independent of story flags. Child trade quest does not have
// this limitation because duping by re-trading isn't possible there.
uint16_t tradeItemNum = GetTradeItemIndex(itemId);
uint32_t traded = (z64_file.scene_flags[0x62].unk_00_ & (0x1 << tradeItemNum)) != 0;
if (itemId >= Z64_ITEM_POCKET_EGG && itemId <= Z64_ITEM_CLAIM_CHECK && !CFG_ADULT_TRADE_SHUFFLE) {
return itemId < z64_file.items[Z64_SLOT_ADULT_TRADE] || traded;
}
return traded;
}

when you don't have anything in the trade slot, z64_file.items returns 0xFF as a uint8_t so the comparison actually returns true