Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using the native TW import UI #1

Open
twMat opened this issue Jul 28, 2019 · 7 comments
Open

Enable using the native TW import UI #1

twMat opened this issue Jul 28, 2019 · 7 comments

Comments

@twMat
Copy link

twMat commented Jul 28, 2019

After much confusion I now notice that a JSON bundle has a different JSON format from what shows in the native $:/Import when importing.

I want the show the JSON bundle using the native import UI, i.e this:

image

My interpretation is that for this to work, the JSON bundle has to use the

  • native TW import JSON format
  • plugin-type:import
  • status:pending
  • type:application/json

I'm not sure this is a "FederationExtended" issue and not a "FederationCore" issue - ?

The reason for wanting this is that users should have to face a minimum number of UIs for importing stuff. A benefit with using a part of the native import UI is also that it should follow the overall dev of TW.

@inmysocks
Copy link
Member

This needs to have context and a clear set of objectives.

https://github.com/OokTech/TW5-FederationExtended/blob/master/.github/ISSUE_TEMPLATE.md

@twMat
Copy link
Author

twMat commented Jul 28, 2019

Sure. The only practical guidance in the link states "If you are going to request a new feature than make sure to describe it completely" so here's an attempt:

OP objectives
Harmonize the UX for using the FederactionCore with common DnD import that uses the native $:/Import UI. The reason for this is to:

  • minimize the number of UI's the user must face
  • piggy back on the features seen in native $:/Import tiddler, e.g preview tiddler content.
  • piggy back on further improvements of the $:/Import UI

Context

  • My UI will have preset the fetching so that it fetches a JSON bundle and then navigates to an equivalent of the $:/Import tiddler where the user can futher explore the tiddler content before finally importing.

Notes
So, one reason for asking to make the JSON bundle follow native TW format is to not have to bother you with further questions about how to access the tiddler content (e.g to present "preview cards") but instead I can ask others.

Also, anyone else who wants to build on top of this would be able to do so if they are able to use the JSON bundle directly, i.e follows native JSON format, which is why I think this is probably a more a FederationCore matter and not a FederationExtended matter.

The end objective is a unified UI for all importing variants, i.e FederationCore, TWederBob, plugin libaries and DnD (any missing?). These four variants have some "workflow steps" in common and it is these steps that should have the same UI. I firmly believe "federation" will be big in the community - but a prerequisite is a good UX. A unified UI is a key component in this.


If the above is insufficient as "context and objectives" I'd appreciate some specific example of what is requested. Jed, I appreciate your help and fully understand that you require this.

@inmysocks
Copy link
Member

inmysocks commented Jul 29, 2019

Sorry to be so hash about this but it keeps going bit by bit like asking for JSON imports which from what I can tell have nothing to do with what you are actually asking for and that wastes time for both of us.

There isn't any part of either of your posts I can point to and say 'this is what the request is'

I am guessing, which is something I shouldn't have to do reading a feature request, that what you want is:

"I want to be able to import a bundle from a remote wiki and instead of importing a bundle which I have to unpack, it goes directly to the native TW import UI with all of the fetched tiddlers."

Which covers everything.
It is stated in the form 'I do something and get this outcome', and because almost equivalent functionality is available elsewhere it describes how this is different from using the action-tiddlerbundle widget with the $useImport option.
I can make that in less time than it took to try and guess what the outcome you want is.

The things that are missing in what you said:

  1. The context for when this happens
  2. What I do to make this happen
  3. What the difference is between using the $useImport option of the unbundling widget is and what you are requesting
  4. What the relevance of saying it has to be a JSON bundle is, that has absolutely nothing to do what what I understand the request to be.

As is listed here: https://ooktech.xyz:8443/Public#How%20to%20make%20a%20good%20feature%20request

That is also linked to as more detail about making feature requests is the post I made above.

I need the end goal, what the experience is like and for the the explanation to in terms of what the experience is, not be in terms of what you think that the technology that could be used to do it.

@twMat
Copy link
Author

twMat commented Jul 29, 2019

"I want to be able to import a bundle from a remote wiki and instead of importing a bundle which I have to unpack, it goes directly to the native TW import UI with all of the fetched tiddlers."

Yes, that.

I don't know why I fail so badly in my communication with you, but I can assure you that it is not from lack of trying. Thank you for your patience.

@twMat
Copy link
Author

twMat commented Jul 31, 2019

I can make that in less time than it took to try and guess what the outcome you want is.

Friendly bump. If it is such a small thing to make it, it'd be great if it was done as soon as you have time. My summer vacations are over in about 1.5 weeks after that I'll have significantly less chances to fiddle with these things. Or is any information lacking from my side?

@inmysocks
Copy link
Member

I thought I had pushed the changes. There is a new version of the core and this on the public wiki.

@inmysocks
Copy link
Member

Neither is well tested, so it may just break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants