Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbuild --clean should not print warnings about configuration mistakes #1780

Closed
ReinhardKeil opened this issue Sep 18, 2024 · 2 comments
Closed
Assignees
Labels
discussion Indicates an issue being in discussion enhancement New feature or request

Comments

@ReinhardKeil
Copy link
Collaborator

The Problem To Be Solved

I don't think that cbuild with option --clean should output warnings about configuration mistakes. It does not feel right.

An output example (of a converted solution) using the new MDK Middleware pack:

C:\Test\Blinky-LPC1700\Boards\Keil\MCB1700\Blinky>cbuild Blinky.csolution.yml --clean
warning csolution: 'Blinky_Release.sct' this linker script is ignored; multiple linker scripts defined
warning csolution: 'Blinky_Release.sct' this linker script is ignored; multiple linker scripts defined
C:/Test/Blinky-LPC1700/Boards/Keil/MCB1700/Blinky/Blinky.cproject.yml - warning csolution: dependency validation for context 'Blinky+Release' failed:
MISSING_API Keil::Board Support&MCB1700:Buttons
MISSING_API Keil::Board Support&MCB1700:[email protected]
MISSING_API Keil::Board Support&MCB1700:LED
MISSING_API Keil::Board Support&MCB1700:[email protected]
warning csolution: 'Blinky_Release.sct' this linker script is ignored; multiple linker scripts defined
C:/Test/Blinky-LPC1700/Boards/Keil/MCB1700/Blinky/Blinky.cproject.yml - warning csolution: dependency validation for context 'Blinky+Debug_RAM' failed:
INCOMPATIBLE ARM::CMSIS-View:Event Recorder&[email protected]
  deny Compiler:Event Recorder
MISSING_API Keil::Board Support&MCB1700:Buttons
MISSING_API Keil::Board Support&MCB1700:[email protected]
MISSING_API Keil::Board Support&MCB1700:LED
MISSING_API Keil::Board Support&MCB1700:[email protected]
+-------------------------------------
(1/3) Cleaning context: "Blinky+Debug"
(2/3) Cleaning context: "Blinky+Release"
(3/3) Cleaning context: "Blinky+Debug_RAM"
+-------------------------------------
@ReinhardKeil ReinhardKeil added the enhancement New feature or request label Sep 18, 2024
@ReinhardKeil ReinhardKeil changed the title cbuild --clean should not print warnings about configuration mistakes cbuild --clean should not print warnings about configuration mistakes Sep 18, 2024
@ReinhardKeil ReinhardKeil added the discussion Indicates an issue being in discussion label Sep 18, 2024
@jkrech jkrech moved this to Backlog in CMSIS-Toolbox 2.7.0 Oct 15, 2024
@soumeh01
Copy link
Collaborator

soumeh01 commented Nov 8, 2024

Cleaning is a two-step process.

  1. The first step involves generating build files such as cbuild-idx.yml and cbuild.yml. These files provide information on the directories that need to be cleaned.
  2. The second step is to perform the cleaning, using the directory information gathered in the first step.

Therefore, the warnings seen during the cleaning process are due to the dependency of the second step on the successful generation of these build files.

@ReinhardKeil
Copy link
Collaborator Author

ReinhardKeil commented Nov 8, 2024

I'm unsure if clean should be that clever.

We have a few other issues that are related:

Let's have a discussion next week.

@soumeh01 soumeh01 moved this from Backlog to In progress in CMSIS-Toolbox 2.7.0 Dec 2, 2024
soumeh01 added a commit to Open-CMSIS-Pack/cbuild that referenced this issue Dec 4, 2024
## Fixes
- Open-CMSIS-Pack/devtools#1780

## Changes
- The change includes removing dependency on convert command

## Checklist
<!-- Put an `x` in the boxes. All tasks must be completed and boxes
checked before merging. -->

- [x] 🤖 This change is covered by unit tests as required.
- [x] 🤹 All required manual testing has been performed.
- [x] 🛡️ Security impacts have been considered.
- [x] 📖 All documentation updates are complete.
- [x] 🧠 This change does not change third-party dependencies
@soumeh01 soumeh01 moved this from In progress to Done in CMSIS-Toolbox 2.7.0 Dec 4, 2024
@soumeh01 soumeh01 closed this as completed by moving to Done in CMSIS-Toolbox 2.7.0 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Indicates an issue being in discussion enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants